Please move the main.cpp to examples folder

Question

Please move the main.cpp to examples folder

rajaravivarma-r opened this issue 6 years ago · comments

Hi, nice project. I really like the API of the library. I just wanted to say if the main.cpp file could be moved to an examples folder. And when I did a make install, I expected the header files to be installed in the location, but I got the cinatra binary installed.

Can you also please write a wiki page on how to build Boost Standalone ASIO, I keep seeing this in cinatra and feather but the CMakeList has find_package(Boost ... system). Either the README is wrong or the cmake file is.

Thank you.

qicosmos · Answer 1 · Tue Jan 29 2019 19:44:16 GMT+0800 (China Standard Time)

I will adjust the code directory and test Standalone ASIO this week.

RajaRaviVarma · Answer 2 · Tue Jan 29 2019 20:50:36 GMT+0800 (China Standard Time)

Thank you, I can move the code directory if you give me how you want it to be, and create a PR for that. I cannot test the Standalone ASIO though, as I am don't know much about cmake.

qicosmos · Answer 3 · Fri Feb 01 2019 08:53:30 GMT+0800 (China Standard Time)

@rajaravivarma-r
I'm afraid i can't do the work this week, because the Chinese New Year is coming, i will enjoy the holiday with my family. After the holiday i will test Standalone ASIO.

So i wish you could adjust the directory of cinatra, here is an example for you:
https://github.com/greg7mdp/sparsepp
Thank you.

qicosmos · Answer 4 · Mon Feb 18 2019 11:51:16 GMT+0800 (China Standard Time)

@rajaravivarma-r
I have adjusted the code directories, and tested asio standalone, cinatra has already support asio standalone now.

RajaRaviVarma · Answer 5 · Tue Feb 19 2019 16:21:15 GMT+0800 (China Standard Time)

@qicosmos Thanks for the work :)