qfpl / applied-fp-course

Applied Functional Programming Course - Move from exercises to a working app!

Home Page:http://qfpl.io/projects/professional-fp-courses/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

level02: Introduce newtype wrappers near definition of RqType?

endgame opened this issue · comments

Currently, the way level02's Types.hs is laid out puts the newtype definitions of Topic and CommentText a fair way down the screen, and probably "below the fold". I would hoist them above the definitions of Error and ContentType so they're visible when people write the different request constructors. Otherwise people might try to build them out of raw Texts, and then go "oh, that's what this is for".

Moved the newtype definitions to above the RqType defintion and it seemed to work well. Considering this fixed for now. 👍