Optionally use github.com/klauspost/compress

Question

Optionally use github.com/klauspost/compress

AlekSi opened this issue 9 years ago · comments

Alexey Palazhchenko commented 9 years ago

https://github.com/klauspost/compress looks impressive.

I propose to create a subpackage (github.com/qedus/osmpbf/faster? :) ) which imports github.com/klauspost/compress and uses a simple dependency injection to use it.

Going to do it myself in few weeks. If someone can't wait – go ahead, do it. :)

Jon Gillham · Answer 1 · Tue Jul 28 2015 22:24:56 GMT+0800 (China Standard Time)

As far as I can see github.com/klauspost/compress only works for compressing not decompressing. osmpbf only uses decompression right now. Maybe I am confused as to how you want to use it.

Alexey Palazhchenko · Answer 2 · Wed Jul 29 2015 00:30:24 GMT+0800 (China Standard Time)

Yeah, you are right, I was overexcited.

Currently there is only minor speedup on decompression (primarily CRC32 calculation).