Giters

qamarelsafadi / CurvedBottomNavigation

A simple android library which helps you to create a curved bottom navigation

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Error: Call requires API level 26 (current min is 21): setAttributeFromXml [NewApi]

mutairibassam opened this issue · comments

commented

@qamarelsafadi After doing a health check in the code, I found one of the used APIs requires minimum level 26 without putting any condition. So, I did a test in API 24 and caused a run time error.

Before applying any fixes, can you please let me know if you did any test for APIs less than 26?

Code:

CurvedBottomNavigation/curvedBottomNaviagtion/src/main/java/com/qamar/curvedbottomnaviagtion/CurvedBottomNavigation.kt

Line 136 in fc119e8

setAttributeFromXml(context, attrs)

CurvedBottomNavigation/curvedBottomNaviagtion/src/main/java/com/qamar/curvedbottomnaviagtion/CurvedBottomNavigation.kt

Line 145 in fc119e8

setAttributeFromXml(context, attrs)

commented

Hey Bassam,
Glad to see your contribution, and yup, unfortunately,
I didn't do any test for APIs less than 26,
I will check your pull request and merge it as soon as possible,
I am still waiting for your Compose contribution,

Have a good day,