pytorch / kineto

A CPU+GPU Profiling library that provides access to timeline traces and hardware performance counters.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Question about how to run "make test" correctly?

PriscillaJCorn opened this issue · comments

Hi guys,
Follow the steps in README.md, I have succeed to build Libkineto. Then, I start to run the tests with the command "make test", but it doesn't change anything. In this CMakeLists.txt file, it seems like that you just add the test folder in this project but do not build anything, so I am very confused about how to "make test" and what is the meanning of

(if tests are built)

Anyway... Could somebody tell me how to build and run the code in the test folder? Thanks

Hi, sorry about this, our README may be outdated. Currently our tests are run internally, and the CMakeLists.txt for our tests directory is incomplete: https://github.com/pytorch/kineto/blob/main/libkineto/test/CMakeLists.txt#L6.

We are open to the open source contributions to get this running in OSS. Currently the Github CI only builds libkineto, but does not test it, would be great to get Github CI running tests too. https://github.com/pytorch/kineto/blob/main/.github/workflows/libkineto_ci.yml#L56

This is a duplicate of #803