pytorch / kineto

A CPU+GPU Profiling library that provides access to timeline traces and hardware performance counters.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Don't hardcode /opt/rocm in CMakeLists.txt

suranap opened this issue · comments

Most HPC systems use Environment Modules to load libraries. Therefore, the ROCm libraries are loaded explicitly by version: module load rocm/5.6.0. On the systems I've used ROCM_PATH is defined as /opt/rocm-5.6.0. I'd suggest changing these lines to ${ROCM_SOURCE _DIR}/lib.

find_library(ROCTRACER_LIBRARY NAMES libroctracer64.so HINTS /opt/rocm/lib)
target_link_libraries(kineto "${ROCTRACER_LIBRARY}")
find_library(KINETO_HIP_LIBRARY NAMES libamdhip64.so HINTS /opt/rocm/lib)

Fixed in #912