Glow windows build failure

Question

mciprian13 opened this issue 3 years ago · comments

With #5838 Glow no longer builds for Windows using Visual Studio because of the following error:

glow\include\glow/Graph/FXIRWrapper.h(140): error C2429: attribute 'nodiscard' requires compiler flag '/std:c++17' [glow_build\lib\IR\IR.vcxproj]

@protonu Can we remove the nodiscard attribute?

Protonu · Answer 1 · Fri Oct 15 2021 00:04:55 GMT+0800 (China Standard Time)

Sure, I'll remove it.

Ciprian Mindru · Answer 2 · Fri Oct 15 2021 17:29:58 GMT+0800 (China Standard Time)

@protonu Thanks for fixing this. This solved my issue. I will close it now.