pytorch / glow

Compiler for Neural Network hardware accelerators

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Potential small issue in Readme.md->"Configure and Build" section

nikola-suljagic opened this issue · comments

Hi everyone,
I am starting with Glow compiler setup, maybe there is small issue in description of executing cmake in section "Configure and Build".
Here is steps described in main Readme.md

mkdir build_Debug
cd build_Debug
cmake -G Ninja -DCMAKE_BUILD_TYPE=Debug ../glow
ninja all

I got path error in third command, because when I follow previous steps I got error that there isn't CMakeLists.txt file.
shouldn't it be:
cmake -G Ninja -DCMAKE_BUILD_TYPE=Debug .. ?
without /glow or maybe to skip command
cd build_Debug
but if we skip cd build_Debug we will pollute root dir?

That is a bit misleading indeed, but it says that the build_Debug directory is expected to be outside the source directory :)

It's also a good idea to build the project outside of the source directory.

So:

├── glow/
├── build_Debug/

Clear clear, thanks :)