pytorch / ci-hud

HUD for CI activity on `pytorch/pytorch`, provides a top level view for jobs to easily discern regressions

Home Page:https://hud.pytorch.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Test button is green but in reality, the test job failed

janeyx99 opened this issue · comments

The problem here is that the failure happened outside of unittest, so it wasn't included in the XML. This is pretty easy to detect (e.g. https://github.com/pytorch/ci-hud/pull/166/files#diff-3ad9e34ce5052427659516e20bceac132c7cd3e4463470c1371d9dd724b11832R139-R141), and once that lands we can unify it to once place do the same thing here (show a message explaining the issue and hide the results button)