`master.utils` submodule fails to import

Question

`master.utils` submodule fails to import

AlexWaygood opened this issue 9 months ago · comments

(venv) C:\Users\alexw\coding\buildmaster-config>python -c "import master.utils"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "C:\Users\alexw\coding\buildmaster-config\master\utils.py", line 3, in <module>
    from jinja2 import Markup
ImportError: cannot import name 'Markup' from 'jinja2' (C:\Users\alexw\coding\buildmaster-config\venv\Lib\site-packages\jinja2\__init__.py)

jinja.Markup doesn't exist with Jinja2==3.1.2.

Not sure if this submodule is really needed? (I don't really know anything about this codebase.)

Victor Stinner · Answer 1 · Fri Sep 29 2023 18:54:42 GMT+0800 (China Standard Time)

REPLACEMENTS and changecommentlink are no longer used. Do you want to propose a PR to remove this file?

Alex Waygood · Answer 2 · Fri Sep 29 2023 19:00:30 GMT+0800 (China Standard Time)

REPLACEMENTS and changecommentlink are no longer used. Do you want to propose a PR to remove this file?

Filed #413 to do that. FYI, I found this by running mypy on the codebase -- was curious to see if it would spot anything obvious after #409 (comment) slipped through unnoticed :-)

Victor Stinner · Answer 3 · Fri Sep 29 2023 19:05:52 GMT+0800 (China Standard Time)

I should run pyflakes to detect such obvious mistake, twice.