Disable Windows 7 on the Python 3.x branch

[Victor Stinner]

Can someone try to propose a PR on https://github.com/python/buildmaster-config/blob/master/master/custom/builders.py to remove Windows 7 from stable buildbots? That would remove them from stable on all Python branches.

The other option would be to hack https://github.com/python/buildmaster-config/blob/master/master/custom/workers.py to exclude 3.x branch from Windows 7 workers.

The last option is to hack https://github.com/python/buildmaster-config/blob/master/master/master.cfg to add a special rule to not schedule jobs on the 3.x branch if "win7" flag is present.

I'm not sure which approach is the best. Maybe @zware or @pablogsal have an opinion on that :-)

[Kyle Stanley]

In builders.py, it seems that the Windows XP builders are still present as well. Could we also remove those from the stable builders since XP is no longer supported by Microsoft?

See:

buildmaster-config/master/custom/builders.py

Lines 104 to 112 in d87219b

 # Windows 
 ("AMD64 Windows7 SP1", "kloth-win64", Windows64Build, STABLE), 
 ("AMD64 Windows7 SP1 VS9.0", "kloth-win64", Windows6427VS9Build, STABLE), 
 ("AMD64 Windows10", "bolen-windows10", Windows64Build, STABLE), 
 ("AMD64 Windows8.1 Non-Debug", "ware-win81-release", Windows64ReleaseBuild, STABLE), 
 ("AMD64 Windows8.1 Refleaks", "ware-win81-release", Windows64RefleakBuild, STABLE), 
 ("x86 Windows7", "bolen-windows7", SlowWindowsBuild, STABLE), 
 ("x86 Windows XP", "bolen-windows", WindowsBuild, STABLE), 
 ("x86 Windows XP VS9.0", "bolen-windows", Windows27VS9Build, STABLE), 

[Zachary Ware]

We'll remove the XP worker and builders when we remove the 2.7 builders.

[Kyle Stanley]

Oh okay, I'll adjust the PR then.

[Kyle Stanley]

It was recently brought to my attention that this issue was already addressed by @vstinner in #171, so I'll close the issue. If there's something that still needs to be addressed, feel free to reopen it.

[Victor Stinner]

Windows XP is only used to test Python 2.7. See master.cfg:

        if "Windows XP" in name and branchname != "2.7":
            # 3.5+ drop support for XP
            continue

[Kyle Stanley]

@vstinner Was the intention to also disable Windows 7 when using the recently added test-with-buildbots label in PRs to 3.x? If so, I just saw a couple of Windows 7 buildbots present when I used it in python/cpython#19149 (AMD64 Windows7 SP1 PR and x86 Windows7 PR).

[Victor Stinner]

@vstinner Was the intention to also disable Windows 7 when using the recently added test-with-buildbots label in PRs to 3.x? If so, I just saw a couple of Windows 7 buildbots present when I used it in python/cpython#19149 (AMD64 Windows7 SP1 PR and x86 Windows7 PR).

I proposed #176 to fix that.