File permissions on uploaded test results are too restrictive

[Zachary Ware]

See this result, for example.

-rw------- 1 buildbot buildbot 4.6M Jan  8 15:54 '/data/www/buildbot/test-results/3.x/PPC64 Fedora 3.x/build_145.xml'

This wasn't true previously, see this result:

-rwxr-xr-x 1 buildbot buildbot 4.6M Jan  7 17:05 build_138.xml

This appears to be due to umask being set to 0077 in the current master process:

$ grep Umask /proc/`pgrep -f buildbot.tac`/status
Umask:  0077

[Pablo Galindo Salgado]

Seems that FileUpload has a mode option:

- ['mode']       file access mode for the resulting master-side file.
                 The default (=None) is to leave it up to the umask of
                 the buildmaster process.

What should be the desired permissions?

[Zachary Ware]

Something world-readable, or at least readable by www-data :). Otherwise, I'm not too bothered.