Initial runtests.py run fails on macOS - ModuleNotFoundError: No module named 'h11'

Question

Initial runtests.py run fails on macOS - ModuleNotFoundError: No module named 'h11'

pquentin opened this issue 6 years ago · comments

On macOS (10.13), running runtests.py fails because h11 is not installed correctly. This has been true since the beginning of runtests.py, even though I'm only reporting it now.

When installing the dev requirements, I expect "Successfully installed h11-0.7.0+dev" but I see "Successfully installed h11". Even though pip reports success, h11 and h11-0.7.0+dev-py3.6.egg-info are not in test-venv-cp36m-macosx_10_13_x86_64/lib/python3.6/site-packages.

Workarounds:

Using venv instead of virtualenv, but we want to support Python 2 eventually so that's not useful
Install h11 manually in the newly created venv
Activate the newly created venv, install an updated wheel, then run runtests.py

I tried to use activate_this.py without much success. I've wasted a lot of time with this issue, so I'm not planning to investigate further, but I thought I would report what I've tried.

Nathaniel J. Smith · Answer 1 · Tue Mar 20 2018 00:18:41 GMT+0800 (China Standard Time)

Do we actually need h11 from git? Can we just switch to installing it from pypi like everything else?

…

On Mar 19, 2018 3:48 AM, "Quentin Pradet" ***@***.***> wrote: Closed #17 <https://github.com/njsmith/urllib3/issues/17>. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/njsmith/urllib3/issues/17#event-1528174723>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAlOaElw_S-zxXGh89tqHsjwda-LAiwRks5tf4zkgaJpZM4Sv8Dp> .

Quentin Pradet · Answer 2 · Tue Mar 20 2018 00:27:49 GMT+0800 (China Standard Time)

The tests do work with h11 0.7.0, yes, even if it's quite old. I'll try to prepare a pull request to this effect. Le lun. 19 mars 2018 20:18, Nathaniel J. Smith <notifications@github.com> a écrit :

…

Do we actually need h11 from git? Can we just switch to installing it from pypi like everything else? On Mar 19, 2018 3:48 AM, "Quentin Pradet" ***@***.***> wrote: > Closed #17 <https://github.com/njsmith/urllib3/issues/17>. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/njsmith/urllib3/issues/17#event-1528174723>, or mute > the thread > < https://github.com/notifications/unsubscribe-auth/AAlOaElw_S-zxXGh89tqHsjwda-LAiwRks5tf4zkgaJpZM4Sv8Dp > > . > — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <https://github.com/njsmith/urllib3/issues/17#issuecomment-374271532>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAClV_IOcWCp_8U3rYXK7vwfN3-rTwo8ks5tf9phgaJpZM4Sv8Dp> .

Quentin Pradet · Answer 3 · Tue Mar 20 2018 02:43:01 GMT+0800 (China Standard Time)

Actually njsmith/h11@75e271c is needed, which was added for the urllib3 tests and is the reason why we're installing from git in the first place. Maybe consider releasing a new h11 version?

Nathaniel J. Smith · Answer 4 · Tue Mar 20 2018 05:39:18 GMT+0800 (China Standard Time)

Ah hah, thanks for tracking that down. And yeah, I'll release a new version.

…

On Mar 19, 2018 11:43 AM, "Quentin Pradet" ***@***.***> wrote: Actually ***@***.*** <njsmith/h11@75e271c> is needed, which was added for the urllib3 tests and is the reason why we're installing from git in the first place. Maybe consider releasing a new h11 version? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/njsmith/urllib3/issues/17#issuecomment-374322180>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAlOaKE0g_t_pXDD4fFmkoDIdEpYYsSCks5tf_w4gaJpZM4Sv8Dp> .