1.11.0: pytest is failing

Question

1.11.0: pytest is failing

kloczek opened this issue 3 years ago · comments

I'm trying to package your module as an rpm package. So I'm using the typical PEP517 based build, install and test cycle used on building packages from non-root account.

python3 -sBm build -w --no-isolation
because I'm calling build with --no-isolation I'm using during all processes oly locally installed modules
install .whl file in </install/prefix>
run pytest with PYTHONPATH pointing to sitearch and sitelib inside </install/prefix>

Here is pytest output:

+ PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-py-1.11.0-2.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-py-1.11.0-2.fc35.x86_64/usr/lib/python3.8/site-packages
+ /usr/bin/pytest -ra
=========================================================================== test session starts ============================================================================
platform linux -- Python 3.8.12, pytest-6.2.5, py-1.11.0, pluggy-1.0.0
rootdir: /home/tkloczko/rpmbuild/BUILD/py-1.11.0, configfile: tox.ini, testpaths: testing
collected 832 items / 1 error / 831 selected
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/usr/lib/python3.8/site-packages/_pytest/main.py", line 269, in wrap_session
INTERNALERROR>     session.exitstatus = doit(config, session) or 0
INTERNALERROR>   File "/usr/lib/python3.8/site-packages/_pytest/main.py", line 322, in _main
INTERNALERROR>     config.hook.pytest_collection(session=session)
INTERNALERROR>   File "/usr/lib/python3.8/site-packages/pluggy/_hooks.py", line 265, in __call__
INTERNALERROR>     return self._hookexec(self.name, self.get_hookimpls(), kwargs, firstresult)
INTERNALERROR>   File "/usr/lib/python3.8/site-packages/pluggy/_manager.py", line 80, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
INTERNALERROR>   File "/usr/lib/python3.8/site-packages/pluggy/_callers.py", line 60, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>   File "/usr/lib/python3.8/site-packages/pluggy/_result.py", line 60, in get_result
INTERNALERROR>     raise ex[1].with_traceback(ex[2])
INTERNALERROR>   File "/usr/lib/python3.8/site-packages/pluggy/_callers.py", line 39, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>   File "/usr/lib/python3.8/site-packages/_pytest/main.py", line 333, in pytest_collection
INTERNALERROR>     session.perform_collect()
INTERNALERROR>   File "/usr/lib/python3.8/site-packages/_pytest/main.py", line 636, in perform_collect
INTERNALERROR>     self.config.pluginmanager.check_pending()
INTERNALERROR>   File "/usr/lib/python3.8/site-packages/pluggy/_manager.py", line 262, in check_pending
INTERNALERROR>     raise PluginValidationError(
INTERNALERROR> pluggy._manager.PluginValidationError: unknown hook 'pytest_funcarg__repowc1' in plugin <module 'conftest' from '/home/tkloczko/rpmbuild/BUILD/py-1.11.0/testing/path/conftest.py'>

======================================================================= 6 warnings, 1 error in 1.76s =======================================================================

Ronny Pfannschmidt · Answer 1 · Fri Jan 14 2022 03:51:29 GMT+0800 (China Standard Time)

expected failure

Tomasz Kłoczko · Answer 2 · Fri Jan 14 2022 06:06:44 GMT+0800 (China Standard Time)

Does it mean that it know bug, or some kind feature which needs some adaptation in other modules? 🤔

Ronny Pfannschmidt · Answer 3 · Fri Jan 14 2022 20:51:46 GMT+0800 (China Standard Time)

its a known breakage - pylib wl not adopt to be testable on modern pytest, its going to be phased out

Tomasz Kłoczko · Answer 4 · Fri Jan 14 2022 21:39:35 GMT+0800 (China Standard Time)

OK now it is clear.
Thx 😄

Tomasz Kłoczko · Answer 5 · Fri Jan 28 2022 23:01:19 GMT+0800 (China Standard Time)

This issue is now affecting probably +10 other modules test suite.
Ronny may I ask you tall few words what needa to be done to get rid of that and/or is irt any working solution for that issue?
Did I push some updates in my packaged modules to far? 🤔

Ronny Pfannschmidt · Answer 6 · Fri Jan 28 2022 23:14:11 GMT+0800 (China Standard Time)

Basically someone would have to forward port the testsuite of pylib to use modern fixtures instead of the initial fixture mechanism,

Currently I'm not aware of anyone wanting to work on that

Im also unlikely to Touch this in a meaningful way anytime soon

As pytest is preparing to completely shed itself from pylib in the mid term future, it's likely that a fix won't happen as it's currently looking like a painful amount of thankless and low value wortk

I understand the pain of not being able to verify a dependency

Florian Bruhin · Answer 7 · Fri Jan 28 2022 23:17:02 GMT+0800 (China Standard Time)

I don't understand how pylib's selftests failing would affect other projects.

Tomasz Kłoczko · Answer 8 · Sat Jan 29 2022 00:38:51 GMT+0800 (China Standard Time)

There are more than few modules affected by that issue.
Just found for example that on update unicoirn to 0.17.1 pytest is failing with the same internal error 😞

Florian Bruhin · Answer 9 · Sat Jan 29 2022 01:10:23 GMT+0800 (China Standard Time)

I doubt unicorn uses an internal conftest.py from pylib's selftest. You are likely looking at a different error.