pystardust / ani-cli

A cli tool to browse and play anime

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Asks for Windows dependencies when inside WSL 2

tekunikaru opened this issue · comments

commented

Metadata
Version: 4.7-1 (From AUR)
OS: Arch Linux on Windows 10 x86_64
Shell: zsh

It doesn't work properly on Arch WSL. When executed, it thinks I'm on Windows (which is technically true).
It gives the following output:

$ ani-cli
Checking dependencies...
Program "mpv.exe" not found. Please install it.

Steps To Reproduce

  1. Start Arch WSL
  2. Install ani-cli from AUR (I used yay)
  3. Run ani-cli

Expected behavior
Dependency check should not ask for Windows applications when inside WSL

Screenshots
image

Additional context
I use Arch WSL 2 on Windows 10 with an X server service for GUI

Hello,

As a contributor who implemented the change to use Windows' mpv.exe for video playback with ani-cli under WSL, I wanted to clarify the rationale behind this approach:

Why Use Windows' mpv.exe with ani-cli in WSL:

  • Stability & Performance: Running GUI Linux applications like mpv in WSL can lead to stability issues. Using Windows' native mpv.exe ensures a smoother video playback experience.
  • Practicality: This workaround leverages the strengths of both environments—ani-cli for fetching streams in WSL and Windows for reliable playback—without the need for complex configurations or additional code to address compatibility issues.

How to use it:

  • Install mpv.exe on Windows.
  • Install ani-cli on wsl
  • Enjoy stable video playback using the best tools from both WSL and Windows.

This solution is designed to optimize the user experience by providing a practical and stable setup for enjoying videos with ani-cli. Your understanding and support in this matter are greatly appreciated.

To revert this change it is enough to remove from ani-cli | *WSL2* in two places.

ani-cli/ani-cli

Line 303 in 0a00507

*MINGW* | *WSL2*) player_function="${ANI_CLI_PLAYER:-mpv.exe}" ;; # Windows OS

ani-cli/ani-cli

Line 325 in 0a00507

MINGW* | *WSL2*) player_function="vlc.exe" ;;

Pull request for context: #1190