pyrollo / display_modpack

Display modpack for Minetest, provides mods with dynamic display and font display : clocks, signs, and more.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Duplication of mods

Thomas--S opened this issue · comments

Hello,

its seems like the most mods of this modpack exist twice now; there's one version in minetest-mods and the second one in this repository.

Which of those versions is considered the main version, i.e. where should pull requests and issues go to?

How are both versions supposed to stay in sync?

Hi

Now, you can propose pull requests on both minetest-mod mods and this modpack. I'll sync the changes anyway.

At the end, it will be better to send PR to minetest-mod as more people could be able to merge them.

Thanks for your answer.

What do you think about referencing the minetest-mods versions of the mods in this modpack as git submodules, so that manual synchronisation isn't necessary anymore?

The big problem with submodules is that code is not included in downloadable tarball. That's a pity, and in my point of view, prevents their use. Instead I use subtree and just have to pull/push in order to sync.

As soon as Github make it possible to have submodules included in tar I'll use them !

Ok. Thanks for the information! 👍

You"re welcome !

Best thing that could happen to avoid such mess would be a nice and clever mod and dependencies management in minetest engine.