Consider using pr-labeler-action
maresb opened this issue · comments
Description
It's very mildly annoying to remember (and often forget) the no releasenotes label on stuff like pre-commit-ci. Unfortunately labels are not supported by pre-commit.ci. A suggested workaround is to use pr-labeler-action to add the label.
I'm leaning towards this not being worthwhile since adding the label is not actually cumbersome, and it probably doesn't justify adding a new GHA workflow. Unless it could be used for more purposes.
Feel free to close without comment, I'm just using this issue to communicate my findings.
EDIT: My description above was truncated to the first paragraph! I wonder what caused that, because that could cause significant loss of work.
pre-commit-ci is really annoying. Dependabot adds the label automatically.
In a lot of instances it's really convenient, but ya, for PyMC stuff we've had a lot of weird issues with it. Do you think we should switch back to GHA?
In a lot of instances it's really convenient, but ya, for PyMC stuff we've had a lot of weird issues with it. Do you think we should switch back to GHA?
I don't remember, what does pre-commit do better? Speed?
It's tough to remember exactly, but off the top of my head...
Speed, yes, which does sometimes come in handy when making a PR and you get quicker feedback when something's off.
It's the more managed option, so no need to maintain a GHA workflow. For most projects it just works.
I'm inclined to just keep it as-is, but in case you do get frustrated then switching back to GHA is viable.
I'm okay with it. My message above was a bit dramatic :)
Decided to keep things as-is.