Adding oauth_token as a valid launch parameter

Question

Adding oauth_token as a valid launch parameter

jichen-amplify opened this issue 6 years ago · comments

Although oauth_token is not required for OAuth's Two-Legged authentication, but it is a valid oauth launch parameter. Apparently, Schoology is mandating it as part of the oauth signature. Could we add 'oauth_token' here as one of the valid launch parameters?

Thanks!

Ryan Hiebert · Answer 1 · Sat Sep 01 2018 00:03:34 GMT+0800 (China Standard Time)

Sounds reasonable to me. Would you like to make a pull request?

Jia Chen · Answer 2 · Sat Sep 01 2018 00:22:54 GMT+0800 (China Standard Time)

Sure, I did try to push my branch to the repo first. But looks like I don't have permission to do so.

Ryan Hiebert · Answer 3 · Sat Sep 01 2018 00:27:24 GMT+0800 (China Standard Time)

You'll have to make a fork, push your branch to your fork, then open up a pull request from that branch on your fork.

Jia Chen · Answer 4 · Sat Sep 01 2018 00:42:01 GMT+0800 (China Standard Time)

Thanks! PR is open.

Jia Chen · Answer 5 · Wed Sep 05 2018 00:45:17 GMT+0800 (China Standard Time)

@ryanhiebert When can we expect this change to be released to pypi?

Ryan Hiebert · Answer 6 · Wed Sep 05 2018 01:22:32 GMT+0800 (China Standard Time)

Done. https://pypi.org/project/lti/0.9.4/

Jia Chen · Answer 7 · Wed Sep 05 2018 01:40:43 GMT+0800 (China Standard Time)

Awesome! Much appreciated!