pylhc / omc3

Python 3 codes for beam optics measurements and corrections in circular particle accelerators

Home Page:https://pylhc.github.io/omc3/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Feature Request]: Make global correction parameter `max_iter` more clear

JoschD opened this issue · comments

commented

Feature Description

A the moment max_iter gives the numbers of re-iterations for the global corrections. That means a value of 0 is zero re-iterations and one correction iteration. This is very confusing.

Possible Implementation

IMHO it should be renamed to iterations and 1 means single iteration corrections, while everything above means more iteration steps.

If we don't change it now (while I am also implementing the connection to the GUI), we will never change it. Any objections?
@lmalina @awegsche @fsoubelet @Mael-Le-Garrec ?

commented

Fixed in #413