Change name of best-knowledge madx file.

[JoschD]

job.create_model.madx is overwritten by best-knowledge model creator (the two creators are called by the GUI in a row).
Maybe should be job.create_bestknowledge_model.madx (see other model creators in python code on how to easily overwrite)

[JoschD]

Related: is the best knowledge model even used in omc3?

• yes! (please check)

[awegsche]

yes, beta_from_phase for example uses the best knowledge model for its model phase advances:

omc3/omc3/optics_measurements/beta_from_phase.py

Lines 489 to 493 in 6763e86

 def _try_best_model(meas_input): 
     if meas_input.accelerator.model_best_knowledge is None: 
         LOGGER.debug("No best knowledge model - using the normal one.") 
         return meas_input.accelerator.model 
     return meas_input.accelerator.model_best_knowledge 

which is ultimately used in lines 84 und 85 of

omc3/omc3/optics_measurements/beta_from_phase.py

Line 69 in 6763e86

 def n_bpm_method(meas_input, phase, plane, meas_and_mdl_tunes): 

[awegsche]

In general it should be used by every model-dependent algorithm like beta_from_phase and both AC-dipole compensation methods (especially Ryoichi's)