Giters

pylhc / omc3

Python 3 codes for beam optics measurements and corrections in circular particle accelerators

Home Page:https://pylhc.github.io/omc3/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Wrong renaming by betabeatsrc_converter

fsoubelet opened this issue · comments

commented

Currently the output of the converter gives us a coupling_f1001.tfs and a coupling_f1010.tfs file, when it should be f1001.tfs and f1010.tfs.

This should be a quick fix.

commented

Also: betabeat.src gives back the units that were given as inputs. when omc3 always gives SI back. At least for now I will add a warning logging that the user should check the input commands from the betabeat.src directory (command.run file) so they're not surprised by the units like I was in the CCC today.

Down the line maybe the converter looks into the command.run file for the input units of betabeat.src and does a conversion (while clearly logging that it did so).