Giters

pylhc / omc3

Python 3 codes for beam optics measurements and corrections in circular particle accelerators

Home Page:https://pylhc.github.io/omc3/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Hole In One Improvements

JoschD opened this issue · comments

commented

Some things that came up when trying to use Hole In One:

  • Probably we should require setting the turns (or at least log a warning if not set) as this should usually be done.
  • Log a warning if turns are not given in ascending order (or throw error)
  • Possible bug in "is_free_kick" as written out into the ini. We thought it was checked, but in the ini it was False. To be checked.
  • Free kick does not seem to check if nat-tunes are present

Documentation Improvements

  • Docstring is not updated. There are missing parameters and outdated info.
  • More details on SVD cut
  • more details on how the svd dominance limit works
  • Explain the different TbT input types
  • Explain the "input unit"
    • When is the data converted (should be: either convert via tbt converter and then hio should be as input in m. Or do not convert beforehand and give the correct unit to hio)
    • All cuts should be in meters (I think)

For the GUI side:

  • is "keep dominant BPMs" still a thing?
  • Sync new HiO parameters (and doc) to GUI settings.