pygy / strung.lua

Lua string patterns rewritten in Lua + FFI, for LuaJIT.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Testing (Travis CI)

pablomayobre opened this issue · comments

Testing would be nice, I think Travis CI is a good choice, kikito has made Travis work with Lua and LuaJIT, here is his configuration. You already have some tests, so this should be really simple, you can later add the badge to this repo and confirm that strung is working even if you make changes to your code.

I can provide a pull rquest by tomorrow, with Travis CI tests, using Busted I will leave the tests as they are, though, and leave the original files there

Excellent idea.

Hi @pygy, since theres no follow up, I'm up to that.

check my branch [specs] and [travis], btw travis results.

if theres anything more that I can do please let me know.

It looks pretty good :-)

We may want to tweak your version so that the new test suite still doubles as a crude benchmark, but I'll do it after the merge.

Any reason for comparing the output with strings and numbers rather than using the output of the string.* functions? The original approach had the advantage of making it trivially easy to write new tests...

Nice, there are plans to make performance tests in busted too.

As for the comparissons, I would like to see the output, but I can change the approach.

Anyway, I was thinking about how would busted could handle these so called performance tests in the future and wonder if isolating your lib methods from standard can play a difference here, like running same tests blocks with different libraries and see the output data.

What are your thoughts on this?