PiFM Translator

Question

PiFM Translator

ramav87 opened this issue 3 years ago · comments

Of particular importance for @rajgiriUW and @kongjy , we are migrating basically all translators out of pycroscopy into their respective packages (most of them go to SciFiReaders). Please advise as to how we should handle the pifm translator. One option is to move it in with the other USID-based translators, which are now in BGLib.

Rajiv Giridharagopal · Answer 1 · Sat Feb 13 2021 04:43:42 GMT+0800 (China Standard Time)

Jess is no longer involved in PiFM so I don't think she has a strong opinion here. But, regarding this case, I think moving the SciFiReaders makes sense, in which case I'll need to update it as I haven't had to use it in awhile.

ramav87 · Answer 2 · Sat Feb 13 2021 05:38:24 GMT+0800 (China Standard Time)

Thanks! It can be ported to bglib without change, but in scifi readers it will need to be changed to sidpy datasets. The change shouldn't take long, though.

…

On Fri, Feb 12, 2021, 3:43 PM Rajiv Giridharagopal ***@***.***> wrote: Jess is no longer involved in PiFM so I don't think she has a strong opinion here. But, regarding this case, I think moving the SciFiReaders makes sense, in which case I'll need to update it as I haven't had to use it in awhile. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#244 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADNDQFOJLBDDCBR62DD6LF3S6WHIZANCNFSM4XRJEYUA> .

Jessica Kong · Answer 3 · Sat Feb 13 2021 05:43:08 GMT+0800 (China Standard Time)

I agree that it makes sense to move it to SciFiReaders given the specific scope of BGLib. Thanks for volunteering to do it, @rajgiriUW. Do let me know if I can help in any way.

Rajiv Giridharagopal · Answer 4 · Wed Sep 15 2021 05:13:07 GMT+0800 (China Standard Time)

I've written a roughly working version in SciFiReaders that converts to sidpy Datasets and then writes via pyNSID to HDF5.
https://github.com/pycroscopy/SciFiReaders/blob/raj-pifm/SciFiReaders/readers/microscopy/spm/afm/pifm.py
https://github.com/pycroscopy/SciFiReaders/tree/raj-pifm

I'll submit a PR when it's validated on a few more sets. Right now having trouble getting the laser power spectrum to write correctly

Rajiv Giridharagopal · Answer 5 · Wed Sep 15 2021 05:14:33 GMT+0800 (China Standard Time)

The PiFM translator is still in pycroscopy. I don't mind where it moves, though BGLib is fine since Phoenix reorg is still ongoing for Pycroscopy

ramav87 · Answer 6 · Wed Sep 15 2021 05:20:04 GMT+0800 (China Standard Time)

We can certainly move it to BGLib for the time being. Would you like me to do so?

Rajiv Giridharagopal · Answer 7 · Wed Sep 15 2021 08:48:04 GMT+0800 (China Standard Time)

Sure, I think that's fine to move there for now-- it doesn't make too much sense there but I guess the idea is hopefully people use the SciFiReaders one once I check it out a little further.