ensure_directory() crashes on my system
fbuchinger opened this issue · comments
The ensure_directory function crashes on my system:
http://github.com/fitzgen/pycco/blob/master/pycco#L238
Why are you using the fragile Popen/mkdir command to create your directory and not the much more solid os.makedirs()?
C:\TEMP\fitzgen-pycco-7f5e254\build\scripts-2.6>python pycco src/*.py
Traceback (most recent call last):
File "pycco", line 264, in
ensure_directory()
File "pycco", line 238, in ensure_directory
Popen(["mkdir", "-p", "docs"]).wait()
File "c:\python26\lib\subprocess.py", line 623, in init
errread, errwrite)
File "c:\python26\lib\subprocess.py", line 833, in _execute_child
startupinfo)
WindowsError: [Error 2] The System can't find the given file
Thanks for reporting this! Can you verify that http://github.com/fitzgen/pycco/commit/5c8faddfd2003fd378a28b9554ed025344faaebc fixes this issue?
I will close this issue and make a minor release as soon as I get confirmation from you.
Hi,
yes, your change fixed this issue, although I'm not 100% lucky with it, but i've created a new issue for this