pyauth / requests-http-signature

A Requests auth module for the IETF HTTP Message Signatures draft standard

Home Page:https://pyauth.github.io/requests-http-signature/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add HTTPSignatureHeaderAuth.verify()

sharpaper opened this issue · comments

The class HTTPSignatureHeaderAuth inherits the method verify() that uses the default scheme="Authorization". It would be nice to override this method such that scheme="Signature" is set automatically:

class HTTPSignatureHeaderAuth(HTTPSignatureAuth):
    def verify(self, request, key_resolver):
        return super().verify(request, key_resolver, scheme="Signature")

I just put this into a Merge Request, linked above. Please feel free to review and add any comments. Thanks for the suggestions.

This is no longer an issue in the latest implementation, which uses only the "Signature-Input"/"Signature" scheme as described in the most recent draft.