Switch to `semantic-version` instead of our custom implementation
Martysh12 opened this issue · comments
Why
According to CONTRIBUTING.md...
Don't reinvent the wheel
We're an open-sourced project, and like most other open-sourced projects, we depend on other projects that already implemented many things which we need in our code. It doesn't make a lot of sense to try and implement everything from the bottom, when there already are perfectly reasonable and working implementations made.
Why not use another thoroughly tested open-source implementation?
Besides, our implementation has a bug:
SemanticVersion.__str__ appends the pre-release string (self.prerelease) without adding a dash -.
So, instead of 2.0.0-1, our implementation outputs 2.0.01. That's wrong.