When using `use_local_fs = true`, go to definition doesn't open a diff buffer
delabere opened this issue · comments
Issue Description
Type: feature request
Describe what happened (or what feature you want)
When I am using the use_local_fs
config option, the benefit is that I can use my local files and lsp to navigate naturally around the code. But when I use go to definition on a newly added function for example in another file, the new function opens up without the side-by-side diff information.
In practice this means I need to select the file from the files changed
panel to open it with this info.
I'd like to provide screenshots but my example is with code I cannot share - let me know if you want me to set up a dummy example for you.
Describe what you expected to happen
I would expect that lsp go to definition would open the same buffer that is opened when I manually select the file from files changed
so that it shows the rich diff and I can navigate the whole PR using lsp
How to reproduce it (as minimally and precisely as possible)
- Create a PR with at least two files
- Create a function or something else in one file that is referenced in the other file
- Make sure you are using
use_local_fs = true
- Have an lsp that supports go to definition with your chosen language
- Review the PR with Octo (Octo [url] && Octo review start)
- Open the file with the reference and go to definition on it
- See that there is no diff information in the buffer and that the left buffer doesn't change from the original file
Tell us your environment
I'm using Go and this version of Octo:
"octo.nvim": { "branch": "master", "commit": "a511b52fbf040f928a24deb72e17ec465613b442" },
Anything else we need to know?
nope :) I love Octo, this is the only feature that is missing to make me stop using the GitHub UI for PR reviews (that and multiline comments/suggestions)
Thanks!!