pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Review submit window might look odd depending on font

igorlfs opened this issue · comments

Issue Description

Type: bug report

Describe what happened

I'm using the Iosevka NF font and when I launch the :Octo review submit, the popup's border looks odd:

image

Many other plugins use borders, and I don't have this issue with any of them. It seems that those plugins are using the same API to create borders, by using nvim_open_win()'s config option, while Octo has its own approach.

Describe what you expected to happen

Well, the border should look normal

How to reproduce it (as minimally and precisely as possible)

  1. Set Iosevka NF as your terminal's font
  2. Search for a PR, start a review and run :Octo review submit

Tell us your environment

I'm on neovim nightly and the only other thing I think could affect this behavior, besides the font, is the smoothscroll option, which is enabled in my setup

Anything else we need to know?

Nah