Octo.nvim runs a slow network-IO-bound shell command during startup
idanarye opened this issue · comments
Issue Description
Type: bug report
Describe what happened (or what feature you want)
After I updated my plugins, Neovim's startup time noticably increased to more than a second. A bit of profiling led to Octo.nvim - specifically to the recently added setup
function of the octo.gh
module. This function runs gh auth status
command, which needs to make network requests against GitHub and delays the entire startup process.
Describe what you expected to happen
This command should run asynchronously so that it wouldn't block Neovim's startup. That is - Octo.nvim's setup will not be complete when require'octo'.setup{}
returns, but instead progress in the background.
How to reproduce it (as minimally and precisely as possible)
- Install Octo.nvim
- Configure Neovim to run
require'octo'.setup{}
on startup. - Run
nvim
Thanks for reporting it. Would you mind testing #479 and checking if it fixes the issue for you?
Yup. That solved it.