pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Unable to start a review and view it

exosyphon opened this issue · comments

Issue Description

Type: bug report

Describe what happened (or what feature you want)

When viewing a PR and executing Octo review start I see the following error message:

Error executing vim.schedule lua callback: ...drew/.local/share/nvim/lazy/octo.nvim/lua/octo/utils.lua:839: BufFilePost Autocommands for "*"..func
tion <SNR>33_on_buffilepost, line 3: Vim(throw):E488: Trailing characters: s:renaming[0] a:bufnr
stack traceback:
        [C]: in function 'nvim_buf_set_name'
        ...drew/.local/share/nvim/lazy/octo.nvim/lua/octo/utils.lua:839: in function 'wipe_named_buffer'
        ...hare/nvim/lazy/octo.nvim/lua/octo/reviews/file-entry.lua:454: in function '_get_null_buffer'
        ...hare/nvim/lazy/octo.nvim/lua/octo/reviews/file-entry.lua:436: in function 'load_null_buffer'
        ...hare/nvim/lazy/octo.nvim/lua/octo/reviews/file-entry.lua:432: in function 'load_null_buffers'
        ...al/share/nvim/lazy/octo.nvim/lua/octo/reviews/layout.lua:203: in function 'file_safeguard'
        ...al/share/nvim/lazy/octo.nvim/lua/octo/reviews/layout.lua:56: in function 'open'
        ...ocal/share/nvim/lazy/octo.nvim/lua/octo/reviews/init.lua:148: in function 'initiate'
        ...ocal/share/nvim/lazy/octo.nvim/lua/octo/reviews/init.lua:56: in function 'callback'
        ...ocal/share/nvim/lazy/octo.nvim/lua/octo/reviews/init.lua:44: in function 'cb'
        ...ew/.local/share/nvim/lazy/octo.nvim/lua/octo/gh/init.lua:119: in function ''
        vim/_editor.lua: in function <vim/_editor.lua:0>

Describe what you expected to happen

To see a diff and the review to start

How to reproduce it (as minimally and precisely as possible)

  1. Octo pr list
  2. Select PR
  3. Octo review start

Tell us your environment

Intel Macbook Pro 2019
Kitty Terminal
Tmux
"octo.nvim": { "branch": "master", "commit": "d1e52f9b3c755fcebb93d635821663a2c0f53281" }

Anything else we need to know?

I see the review starts in the Github webpage so I think it has something to do with rendering the diff

This ended up being an issue with vim-gitgutter. I moved to using GitSigns instead and no longer have this issue.