pypi tarball misses tests
mgorny opened this issue · comments
The tarball uploaded to pypi (for version 1.4.0) does not have the 'tests' directory. I think it should be added to MANIFEST.in.
I'm not familiar with a need to distribute the tests - if you want to run the tests you can just clone the repository, no? Out of interest, are there significant consequences to not distributing the tests?
That said, if you send a pull request I'll happily include it. Is it just a matter of adding include tests, or something else?
I'm not familiar with a need to distribute the tests - if you want to run the tests you can just clone the repository, no? Out of interest, are there significant consequences to not distributing the tests?
It's useful to distro packagers. We want to be able to test the exact sources we're using to build the release package. However, in this case I've just switched the package to build straight out of GitHub snapshots, so it doesn't really matter to me.
That said, if you send a pull request I'll happily include it. Is it just a matter of adding include tests, or something else?
Probably that, I haven't tested.
Fixed, live on pypi now.