pwa-builder / PWABuilder

The simplest way to create progressive web apps across platforms and devices. Start here. This repo is home to several projects in the PWABuilder family of tools.

Home Page:https://docs.pwabuilder.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[BUG] Fix build issue with staging

jgw96 opened this issue · comments

What happened?

Staging has some build issues that are causing our actions to fail.

How do we reproduce the behavior?

  • Open up the actions tab for the latest staging PR.
  • Observe the type errors on the main site build action

What do you expect to happen?

No response

What environment were you using?

OS: Windows 11

Additional context

No response

Fixed for now by adding skipLibCheck to the sites tsconfig. The underlying issue is that the code-editor uses lodash-es, which does not compile with the version of TypeScript we use, or even the latest version. Because of this, I am going to close this issue as the build is fixed, and open a new issue to move our code-editor component away from using lodash-es (or just lodash at all)