Username is 0 in IRC/WOL protocol
Sora012 opened this issue · comments
I've compiled PvPGN on both docker (Debian/Ubuntu/Alpine from Develop, and a known good commit), and manually (Archlinux from Develop, and a known good commit) but for some odd reason, the IRC/WOL protocol seems to be broken
I've tested against g++ and clang, Arm, and x86_64.
Basicallly usenames show up as "0" if you join the channel last. If the user who is '0' leaves and rejoins the channel it shows three names. "User1, User2, 0" The system logs are showing no symptoms, and are using the proper names. I thought perhaps it was related to WOL, so we tried IRC clients on PvPGN, but its the same issue.... IRC clients show "User1User2" in the same name.
Is this by chance a newer library issue?
Notes:
- This occuring also limits text chat e.g. clients cannot communicate.
- Example images are from Red Alert 2
The log file. This log doesn't match the images above, as its just myself running two clients locally, but they have the same issue.
The following patch file fixes the following issues #433 #197 and #461.
I have tested this a few times with Red Alert 2, Renegade. HexChat.
I haven't encountered any issues using this patch so far.
IRC:
The IRC username tree for channels being "User1User2User3" all in one name, has been fixed.
WOL:
Renegade no longer crashes during login.
Renegade can see Dedicated Servers & Join
Chat channels no longer show "0, User1, User2" and prevents clients from communicating.