about androidx.annotation.NonNull

Question

about androidx.annotation.NonNull

dohard-ma opened this issue 5 years ago · comments

dohard commented 5 years ago

Thank you very much for releasing the new package on NPM.

But now I have some other problems, androidx.annotation.NonNull throw out error

I don't think this import is used. Can you remove it?

Juan Guillermo Rivera Orozco · Answer 1 · Thu May 30 2019 23:18:29 GMT+0800 (China Standard Time)

Hi @MaShizhen any updates on this? I am experiencing the same error

Corey Wilson · Answer 2 · Thu May 30 2019 23:29:06 GMT+0800 (China Standard Time)

I'm traveling for the next week so I don't have an android device to test out but if someone can verify removing that import fixes the issue for you guys I can deploy the fix.

Juan Guillermo Rivera Orozco · Answer 3 · Thu May 30 2019 23:47:08 GMT+0800 (China Standard Time)

Sure, give me a moment and I can test on my devices. Let you know how it goes. Thanks @pusherman

Juan Guillermo Rivera Orozco · Answer 4 · Fri May 31 2019 00:36:44 GMT+0800 (China Standard Time)

Hi, I already tested on my Android device and it worked.
I just removed this line from the code https://github.com/pusherman/react-native-network-info/blob/v5.0.0/android/src/main/java/com/pusherman/networkinfo/RNNetworkInfo.java#L6

Corey Wilson · Answer 5 · Fri May 31 2019 01:11:45 GMT+0800 (China Standard Time)

Removed in v5.0.1

Thanks guys!