purescript-contrib / purescript-routing

A clean, type-safe routing library for PureScript.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Rename `matchHash` and `matchHash'`

menelaos opened this issue · comments

The guide mentions that this library only supports hash-based routing. The actual matching, however, is completely agnostic to where it gets the URL string from:

matchHash :: forall a. Match a -> String -> Either String a
matchHash' :: forall a. (String -> String) -> Match a -> String -> Either String a

I would thus propose to drop the Hash part and rename the above two functions into match and either match' or matchWith. If you approve of this, I will open a PR later today.

match and matchWith sounds good to me 👍