Giters

pupilfirst / pupilfirst

A learning management system (LMS) that lets you run an asynchronous online school, where learning is achieved through focused tasks, directed feedback, an iterative workflow, and community interaction.

Home Page:https://www.pupilfirst.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Archived submissions are being counted in the cohort overview and student pages

harigopal opened this issue · comments

commented

Describe the bug
When a student's reviewed submissions are archived from the back-end, they're still being counted in the cohort overview and students pages that coaches have access to, even though these are (properly) not considered in the any student report page.

To Reproduce
Steps to reproduce the behavior:

  1. Archive an accepted submission from the backend.
  2. Visit the cohort_path for the cohort in question.
  3. View incorrect completion count againt the related assignment.
  4. Click the assignment name to visit the students page with the filter set.
  5. View the completion attributed to student, even though submission has been archived.

Expected behavior

  1. The count on index page should not consider archived submissions.
  2. The students page filter for milestone completion should ignore archived submissions.