Incorrect Rack::RELEASE comparison in test_rack_server.rb

Question

Incorrect Rack::RELEASE comparison in test_rack_server.rb

ron-shinall opened this issue a year ago · comments

Describe the bug
The Rack::RELEASE version comparison for requiring Rack::Chunked is incorrect in test/test_rack_server.rb.

If the Rack::RELEASE is "3.1" the following evaluates to true and therefore requires rack/chunked when it should not be (as of 3.1):
require "rack/chunked" if Rack::RELEASE.between?('3', '3.1')

This was changed in #3064

Expected behavior
A comparison more like this is what is required:
require "rack/chunked" if Rack::RELEASE >= '3' && Rack::RELEASE < '3.1'

MSP-Greg · Answer 1 · Wed Mar 15 2023 23:25:00 GMT+0800 (China Standard Time)

@ron-shinall

Thanks. My mistake.

I'll fix soon with Rack::RELEASE.start_with? '3.0'. For others, no versions of Rack 3.1 have been released, and current master is '3.0.0'.

Ron Shinall · Answer 2 · Wed Mar 15 2023 23:26:16 GMT+0800 (China Standard Time)

@MSP-Greg Thanks for the quick response! I appreciate your efforts.