Time to change to require_relative?

Question

Time to change to require_relative?

MSP-Greg opened this issue 2 years ago · comments

Have a branch prepared for a PR, so I thought I'd ask first.

Any reason to not change all require statements to require_relative?

See https://github.com/ruby/ruby/search?q=require_relative, and #2381

Ruby master has now copied all the methods Puma used from io/wait to IO. I originally started the PR for that, as io/wait won't need to be required for Ruby 3.2 and later. I.think. I haven't tested it yet, but I think the only methods used in Puma are wait_readable and wait_writable...

Nate Berkopec · Answer 1 · Tue Jul 12 2022 06:30:51 GMT+0800 (China Standard Time)

Can we avoid breaking CentOS?

MSP-Greg · Answer 2 · Tue Jul 12 2022 07:13:23 GMT+0800 (China Standard Time)

Can we avoid breaking CentOS?

I interpreted #2381 to mean that all ruby files could be loaded with require_relative, but any *.so files needed to be loaded with require. We only have one puma_http11.

We could use require_relative, and if an error is raised, load via require...

Nate Berkopec · Answer 3 · Thu Jul 14 2022 06:38:00 GMT+0800 (China Standard Time)

Cool! Full speed ahead then 🚆