puma / puma

A Ruby/Rack web server built for parallelism

Home Page:https://puma.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

"Invalid request command: pumactl refork"

slondr opened this issue · comments

Describe the bug
I run puma in refork mode, but when I run pumactl refork I just get:

Invalid request command: refork

refork does appear in the list of available commands when I run pumactl --help. Sending SIGURG to the main puma process works fine. Other pumactl commands, such as gc and stats, work fine.

Desktop (please complete the following information):

  • OS: Ubuntu Linux
  • Puma Version 5.5.0

@slondr

Thanks for the report.

Looks like a bug that still exists in master. If one has a control url set, it won't send a refork signal. I think the line in the Puma::ControlCLI#run method:

if Puma.windows? || @control_url

Should be:

if Puma.windows? || @control_url && !NO_REQ_COMMANDS.include?(@command)

Haven't looked at a test yet...