EKS cluster templates should use get_int
aaronkao opened this issue Β· comments
aaronkao commented
Hello!
- Vote on this issue by adding a π reaction
- If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)
Issue details
This currently uses get_float
and should be get_int
instead because you can't provision a fraction of an instance.
Affected area/feature
The default's won't cause errors however if someone does manage to input a float number, AWS would throw this error ["Encountered non numeric value for property DesiredCapacity"]
diana esteves commented
A few more values that should be represented as ints across the templates repo can be found here https://github.com/search?q=repo%3Apulumi%2Ftemplates%20float&type=code