pulumi / templates

Templates used by `pulumi new`

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

EKS cluster templates should use get_int

aaronkao opened this issue Β· comments

Hello!

  • Vote on this issue by adding a πŸ‘ reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

https://github.com/pulumi/templates/blob/ad915fc3e3558493cbc689e5fa529500c359999b/kubernetes-aws-python/__main__.py#L7C57-L7C57

This currently uses get_float and should be get_int instead because you can't provision a fraction of an instance.

Affected area/feature

The default's won't cause errors however if someone does manage to input a float number, AWS would throw this error ["Encountered non numeric value for property DesiredCapacity"]

A few more values that should be represented as ints across the templates repo can be found here https://github.com/search?q=repo%3Apulumi%2Ftemplates%20float&type=code