pullpreview / action

A GitHub Action that starts preview deployments for your pull requests and branches. It can work with any application that has a valid Docker Compose file.

Home Page:https://pullpreview.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Wildcard subdomain support

danstewart opened this issue · comments

Hi,

Any chance of supporting wildcard subdomains?

We have multiple tenants accessed by subdomain, so it would be handy to be able to access the preview for each tenant.

Thanks

Hello,

Not with the default setup, because Let's Encrypt does not support wildcard certificates with the http challenge. I think it might work in two cases though:

  • use caddy with the on-demand TLS option, so that it can deliver certificates for your subdomains (https://caddyserver.com/docs/automatic-https#on-demand-tls)
  • use your own preview domain with pullpreview (domain input, like previews-mycompany.com), and configure caddy or some other proxy to use the DNS challenge to generate the wildcard certificate for our domain

Thanks for the info.

We actually are using a custom domain, so does *.{our custom domain} already have the DNS configured to point to our lightsail?

Yes!

Great, thank you, we'll give that a try!