Giters

publiclab / spectral-workbench

Web-based tools for collecting, analyzing, and sharing data from a DIY spectrometer

Home Page:http://spectralworkbench.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add routes test for spectrums/clone_search

Tlazypanda opened this issue · comments

commented

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file routes_test.rb in the spectral-workbench repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in read (and a -) which lines to remove, and in green (and a +) which lines to add:

+  test "test get request for spectrums clone_search" do
+    assert_routing({ path: '/spectrums/clone_search', method: 'get' }, {controller: 'spectrums', action: 'clone_search'})
+  end

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

commented

Hey @Tlazypanda, I'm a first-time contributor. Can you please assign me this issue?

commented

Hey @saikmusunuri go ahead :)

commented

Unassigning this there have no updates from @saikmusunuri

commented

@TildaDares, I'm going to start it by the end of this week, could you please give me some time. Thanks!

commented

Hi @saikmusunuri, sure take all the time you need.

commented

Can you please reassign me?

commented

Thank you

commented

Hi @saikmusunuri, any updates on this? We can always assign you to another issue when you are ready so that another first-timer can work on this.

commented

Hey @TildaDares, I'm already learning to work on it. I will start the work very soon.

commented

Hey @TildaDares Please assign this issue to me.
I've made the changes and I'll be creating a PR in a while.

commented

Hi @saikmusunuri, it's totally fine if you're busy right now. I can put your name in the first-timers only list so that when there's an available FTO, you can be assigned to it. Does that sound good?

commented

Sounds good! That works for me.
Sorry for the delay.

commented

Thank you @TildaDares for assigning this to me :)