Giters

publiclab / spectral-workbench

Web-based tools for collecting, analyzing, and sharing data from a DIY spectrometer

Home Page:http://spectralworkbench.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Port Geocode tool back into new Capture interface, next steps

Georjane opened this issue · comments

commented

@jywarren and @Tlazypanda
I think I will be picking up this issue next from publiclab/spectral-workbench.js#265

thank you

commented

Hi @Tlazypanda @TildaDares @jywarren 👋🏽

I was able to upload my first spectrum today locally.
I was trying to test the functionality of the geocoding tool on the old capture interface to compare it with the new capture/v2 version.
But I realized from this comment here that geocoding of the spectrum doesn't work anymore.
Please I would like to understand exactly what the geocode button is expected to do. Thank you
image

commented

I was also facing the error below when I added the geocode button from the old capture interface to the new capture v2. I tried debugging but to no avail. 😞
image

commented

Hey @Georjane the Geocode part not working is what we are discussing on the call - the part where I mentioned that the params are not getting saved correctly on to the backend which is why it stopped working. Hence it's not included in the second version so we need to add it and get it working ✨

This error suggests that data variables passed as an argument here is actually nil, can you log the data variable here reference - https://stackoverflow.com/questions/57197682/in-decode64-undefined-method-unpack1-for-nilnilclass-nomethoderror

commented

I believe the geocode button requests a location from the browser API for location, then it tries to attach it to the form using hidden inputs with ID #lat and #lon:

spectral-workbench/app/assets/javascripts/capture.js

Line 340 in 8f89e0f

geolocate: function() {

Hope that helps! It uses a callback so the code is a little tangled, but it's not too long!

commented

Hey @Georjane the Geocode part not working is what we are discussing on the call - the part where I mentioned that the params are not getting saved correctly on to the backend which is why it stopped working. Hence it's not included in the second version so we need to add it and get it working ✨

This error suggests that data variables passed as an argument here is actually nil, can you log the data variable here reference - https://stackoverflow.com/questions/57197682/in-decode64-undefined-method-unpack1-for-nilnilclass-nomethoderror

Hi @Tlazypanda
please i have difficulties understanding this line of code $('#geotag').val('true'!=$('#geotag').val())
Thank you!

commented