Giters

publiclab / spectral-workbench

Web-based tools for collecting, analyzing, and sharing data from a DIY spectrometer

Home Page:http://spectralworkbench.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

login button not clickable on hover i.e. cursor isn't pointer.

celeroncoder opened this issue · comments

commented

What happened just before the problem occurred

When hovering over the login button in the drop-down and navbar the login button does not show as clickable and shows as normal text.

Relevant URLs

https://spectralworkbench.org/

PublicLab.org username

username: khushalbhardwaj0111

Steps to see the issue:

  • Go the https://spectralworkbench.org/
  • Hover over the login button (if not logged in)
  • It does not appear as a clickable button like the others, i.e, cursor: pointer is not there.
  • Also, the the login option in the dropdown does not appear clickable as well like a button.

output

Browser, version, and operating system

Mozilla Firefox 95.0.1 64-bit, Ubuntu 21.10

For bug reports, fill out the above template; for feature requests, you can delete the template.

commented

Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
Do join our Gitter channel for some brainstorming discussions.

commented

Hi @khushalbhardwaj-0111 , I think I can resolve this issue , Can you just give me your permission to go with it?

commented

@Kunal0220 sure go ahead, I am not that familiar with frontend and ruby so won't be able to help though. You can ask for other folks contributing in the project to guide you through, I am a beginner to this project 😺.

commented

@Tlazypanda could you plz assign this issue to @Kunal0220 .

commented

Hey @khushalbhardwaj-0111 nice catch! Assigning to @Kunal0220 I think the relevant file to be modified is the _header.html.erb file in app/layouts directory. Happy Opensourcing 💙

commented

Thank You @Tlazypanda ,
I'll try to fix this ASAP , as I am new to Open Source , If i get stuck , I'll come back to this place for your guidance.

commented

Hey @Tlazypanda I have figured out the point where the code is breaking and have found the solution to it.

Spectral-Workspace.mp4

But the issue is that I am not very comfortable with RubyOnRails(ROR) , can you please help in figuring out that how do I have to integrate the html changes that I found in ROR?

commented

BTW I have done these changes in the Console and not in the codebase!

commented

Hey @Kunal0220 I believe the changes to be made are in the _header.html.erb file as mentioned below so the idea way to go about would be to setup the repository locally following the steps mentioned in the readme and then changing the file https://github.com/publiclab/spectral-workbench/blob/main/app/views/layouts/_header.html.erb lines 63 and 20 (please verify this once) and then testing it out locally. Then if it works fine you can raise a pr for changes in just this file with a screenshot reflecting the cursor change and we are good to go!

commented

@Tlazypanda I am looking to this ASAP , ThankYou :)