Replace var keyword with let/const

Question

Replace var keyword with let/const

Julietadeboye opened this issue 2 years ago · comments

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from underrepresented groups in free and open-source software!

We know that the process of creating a pull request is one of the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

🙋 Claim this issue: Claim the issue by commenting. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

💡 Learn how to claim 🙋

Claiming an issue

Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.

And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.

📝 Update the file sw.js in the publiclab/plots2 repository by replacing the var keywords with let/const (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

- 9  for (var i = 0; i < clientList.length; i++) {
+ 9  for (let i = 0; i < clientList.length; i++) {
-  10  var client = clientList[i];
+  10 let  client = clientList[i];

💾 Commit your changes
🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

🏁 Done Ask in the comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming the first-timers-only issue. We're happy to keep it assigned to you as long as you need it if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below, and reach out in our chatroom!

welcome · Answer 1 · Thu Oct 13 2022 16:26:17 GMT+0800 (China Standard Time)

Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
Do join our Gitter channel for some brainstorming discussions.

Juliet Adeboye · Answer 2 · Thu Oct 13 2022 16:26:47 GMT+0800 (China Standard Time)

@TildaDares

Tilda Udufo · Answer 3 · Thu Oct 13 2022 16:31:42 GMT+0800 (China Standard Time)

Hi @Julietadeboye, thank you for opening this issue. Please take a look at this issue to know the required format for an FTO #11472.

Thank you!

Juliet Adeboye · Answer 4 · Thu Oct 13 2022 17:05:02 GMT+0800 (China Standard Time)

Hi @TildaDares i made the necessary edits, thanks

Tilda Udufo · Answer 5 · Thu Oct 13 2022 19:22:28 GMT+0800 (China Standard Time)

Thank you @Julietadeboye!

The link to the file is incorrect, do you think you could add the correct one? Thanks!

Juliet Adeboye · Answer 6 · Thu Oct 13 2022 19:54:56 GMT+0800 (China Standard Time)

Thanks for pointing this out, the URL has been corrected @TildaDares

Tilda Udufo · Answer 7 · Thu Oct 13 2022 21:45:17 GMT+0800 (China Standard Time)

Reserved for @Josephsanya for 24 hours!

Tilda Udufo · Answer 8 · Thu Oct 13 2022 21:46:17 GMT+0800 (China Standard Time)

@Julietadeboye Would you mind informing @Josephsanya that an issue has been reserved for them in #11105?

Thank you!

Jhowsef · Answer 9 · Thu Oct 13 2022 21:50:24 GMT+0800 (China Standard Time)

Thank you @TildaDares
I'll start working on it now

Jhowsef · Answer 10 · Thu Oct 13 2022 22:46:27 GMT+0800 (China Standard Time)

Please can you review my PR at #11476 @TildaDares
Thanks.