publiclab / matcher-cli

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

📝 Update: Add to README the process the algorithm that's used to detect and filter commands below. We recommend you to run the library and set up breakpoints to familiarize yourself with this!

matcher-cli/matcher.js

Lines 27 to 38 in 0bf7186

    
           async function vorpalify(args) { 
        
             const {query} = args; 
        
             // eslint-disable-next-line no-unused-vars 
        
             const summoner = await commands.summoner; 
        
             if (eval(`commands.${query}`) !== undefined) { 
        
               eval(`commands.${query}()`); 
        
             } else if (eval(`summoner.${query}`)) { 
        
               console.log(eval(`summoner.${query}`)); 
        
             } else { 
        
               error(`Invalid command: "${query}", exiting...\n`); 
        
               process.exit(); 
        
             }

💾 Commit your changes
🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

Hi, can I pick this one?

thx

Sure! Go ahead! Pranshu Srivastava | @rexagod

…

On Thu, 29 Aug 2019, 18:15 spassaro80, ***@***.***> wrote: Hi, can I pick this one? thx — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#11?email_source=notifications&email_token=AIAAUZ7PU27JHTD7BRFD3JTQG7AEZA5CNFSM4IPOWGNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5OLATA#issuecomment-526168140>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIAAUZ5E2QF2YONDDWUW4ZTQG7AEZANCNFSM4IPOWGNA> .

Hi, New contributor here. want to pick it.

Sure! Go ahead! Pranshu Srivastava | @rexagod

…

On Sat, 31 Aug 2019, 13:53 aishukamble, ***@***.***> wrote: Hi, New contributor here. want to pick it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11?email_source=notifications&email_token=AIAAUZ6LHGQK27L6XTZWIL3QHIS6JA5CNFSM4IPOWGNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5TIDSY#issuecomment-526811595>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIAAUZ4XB42YG4MC753QC3TQHIS6JANCNFSM4IPOWGNA> .

Hi

I've tried to run matcher.js in node.js but it by it gives me this error. I'm sure I'm doing something wrong, I'll try to find what it is :).

Server's up @ http://127.0.0.1:9990

(node:7708) UnhandledPromiseRejectionWarning: Error: net::ERR_CONNECTION_REFUSED at http://127.0.0.1:9990/demo/
at navigate (C:\Users\00070261\matcher-cli\node_modules\puppeteer\lib\FrameManager.js:121:37)
at process._tickCallback (internal/process/next_tick.js:68:7)
-- ASYNC --
at Frame. (C:\Users\00070261\matcher-cli\node_modules\puppeteer\lib\helper.js:110:27)
at Page.goto (C:\Users\00070261\matcher-cli\node_modules\puppeteer\lib\Page.js:629:49)
at Page. (C:\Users\00070261\matcher-cli\node_modules\puppeteer\lib\helper.js:111:23)
at invoke (C:\Users\00070261\matcher-cli\src\matcher-summon.js:56:14)
at process._tickCallback (internal/process/next_tick.js:68:7)
(node:7708) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:7708) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

hi can I pick this up?

Hi can i pick this up? Or is it already taken :)

Hi is this issue still being worked on? I would like to help if any is needed? Thanks, first-time contributor here.

	async function vorpalify(args) {
	const {query} = args;
	// eslint-disable-next-line no-unused-vars
	const summoner = await commands.summoner;
	if (eval(`commands.${query}`) !== undefined) {
	eval(`commands.${query}()`);
	} else if (eval(`summoner.${query}`)) {
	console.log(eval(`summoner.${query}`));
	} else {
	error(`Invalid command: "${query}", exiting...\n`);
	process.exit();
	}

Document filtering algorithm

🤔 What you will need to know.

📋 Step by Step

🤔❓ Questions?

Is someone else already working on this?