geocode by string UI bugs
jywarren opened this issue · comments
I documented some odd interactions using this in Firefox Android:
Three are:
- Searching for New Delhi doesn't seem to pan the map
- Zooming out results in a misdrawn red square
- Finger panning then doesn't seem to work
This was on Publiclab.org and should be checked against the latest demo here!
Needs more thorough documentation and breaking up!
@jywarren panning and boxes are okay in the demo but seem to break apart in the publiclab integration. Is the latest demo integrated with publiclab?
Oh thanks! I think it's probably a version behind so we can try upgrading!
…On Sun, Apr 15, 2018, 6:29 AM Mridul Nagpal ***@***.***> wrote:
@jywarren <https://github.com/jywarren> panning and boxes are okay in the
demo but seem to break apart in the publiclab integration. Is the latest
demo integrated with publiclab?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#128 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJxdmh-0ZB4Q9BGR7XKSWE5rM8NHoks5toyDxgaJpZM4TVKr7>
.
Awesome!! Also regarding the search is still an issue, on it. Will post a solution soon!!
Huh - publiclab.org now has the latest, and entering "New Delhi" and
clicking on it now recenters the map, but it seems the zoom control was
lost. Was there a regression in a recent merge?
…On Sun, Apr 15, 2018 at 9:21 AM, Mridul Nagpal ***@***.***> wrote:
Awesome!! Also regarding the search is still an issue, on it. Will post a
solution soon!!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#128 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ_xp9w1sSOz4kXZJAG30pCF9R8csks5to1d8gaJpZM4TVKr7>
.
from these changes?
https://github.com/publiclab/leaflet-blurred-location/pull/96/files
…On Mon, Apr 16, 2018 at 4:22 PM, Jeffrey Warren ***@***.***> wrote:
Huh - publiclab.org now has the latest, and entering "New Delhi" and
clicking on it now recenters the map, but it seems the zoom control was
lost. Was there a regression in a recent merge?
On Sun, Apr 15, 2018 at 9:21 AM, Mridul Nagpal ***@***.***>
wrote:
> Awesome!! Also regarding the search is still an issue, on it. Will post a
> solution soon!!
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#128 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AABfJ_xp9w1sSOz4kXZJAG30pCF9R8csks5to1d8gaJpZM4TVKr7>
> .
>
oh indeed, we're on 1.1.5 instead of 1.1.12... not sure why! I'll ask
Sebastian to change this.
…On Mon, Apr 16, 2018 at 4:25 PM, Jeffrey Warren ***@***.***> wrote:
from these changes? https://github.com/publiclab/leaflet-blurred-
location/pull/96/files
On Mon, Apr 16, 2018 at 4:22 PM, Jeffrey Warren ***@***.***>
wrote:
> Huh - publiclab.org now has the latest, and entering "New Delhi" and
> clicking on it now recenters the map, but it seems the zoom control was
> lost. Was there a regression in a recent merge?
>
> On Sun, Apr 15, 2018 at 9:21 AM, Mridul Nagpal ***@***.***>
> wrote:
>
>> Awesome!! Also regarding the search is still an issue, on it. Will post
>> a solution soon!!
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <#128 (comment)>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/AABfJ_xp9w1sSOz4kXZJAG30pCF9R8csks5to1d8gaJpZM4TVKr7>
>> .
>>
>
>
@jywarren Is this done, or we need to add something?
Yes!!!