publiclab / image-sequencer-app

image-sequencer-app/src/util/converter.js

Line 50 in 5cdf855

    
           let str = rv[0].steps + `,canvas-resize{width:${width + 1000}|height:${height + 1000}|x:${lMins[0].x}|y:${lMins[0].y}}`;

Hi Varun, I could be at the wrong spot here, but I think in the original code corresponding to this, we used the largest dimension to set the size:

https://github.com/publiclab/mapknitter-exporter/blob/c767780392342c109b26a887971b3ab6bcd98c94/lib/mapknitterExporter.rb#L136

Is this a bit less arbitrary than the fix you've used? Or, what are next steps to address this quick fix? Thanks!

Oh yes! This was a temporary fix! This issue is related to the one I have just opened #15 , once we have the scaling done right this space won't be needed!

OK, great. Super!

Change "extra space" fixes