Column subtract button in table popover has no style
NARUDESIGNS opened this issue · comments
Hi @jywarren, trust you're good?
I remember you mentioned where the HTML file for the Public Lab Editor is but I can't seem to remember, can you please remind me?
I found the cause of this issue, it's in the HTML code. The class name was misspelt.
cc @TildaDares
Hi @NARUDESIGNS, @jywarren mentioned it here #752 (comment)
Thank you so much @TildaDares
However, I checked that file and many others but couldn't find the element I'm looking for (decCol). It has a class name of btn-outline-secondaryt. The extra "t" makes the element unable to access the style. Here's an image to show you the element I'm looking for:
Any help?
Hi! Great find on that typo. The line of code is here -- it's a "submodule" of the rich text module!
@jywarren Yea thanks, I think my PR captured that as well. Please have a look at the changes in the code here
NARUDESIGNS@d7e2a0a
Ah, actually @NARUDESIGNS would you mind opening a PR for your changes? It's easier to keep all our reviews in one place then. Thank you!
@jywarren I opened a PR for it here - #758
@TildaDares was kind to review and asked for some changes which I've also completed. I'm waiting for my PRs to be merged. This is one of them, there's another (this one #757 which fixes issue #755)
Was this now resolved? Just checking - we can close it if so!
Was this now resolved? Just checking - we can close it if so!
Yes, you just merged it #758